Refactor the CRS testing tooling a bit: no more macro, retry each task indipendently#534
Conversation
Consolidated Tests Results 2026-05-22 - 07:15:38Test Results
Details
test-reporter: Run #2345
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
There was a problem hiding this comment.
Pull request overview
This PR refactors the threshold CRS test tooling by removing the par_poll_responses! macro, introducing a shared polling helper in threshold/common.rs, and updating the CRS tests to poll each (client, request) pair independently with per-attempt timeouts/backoff.
Changes:
- Replace macro-based polling with
poll_with_retrieshelper. - Update CRS generation tests to use slice-based request passing and
join_allpolling. - Reduce CRS polling log noise by downgrading an
infotodebug.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/service/src/client/tests/threshold/crs_gen_tests.rs | Switch CRS polling to per-(client,request) retry futures; remove macro usage and adjust request passing. |
| core/service/src/client/tests/threshold/common.rs | Add shared poll_with_retries helper and ProtoRequestId alias; import MAX_TRIES for retry control. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Daniel Demmler <daniel.demmler@zama.ai>
kc1212
left a comment
kc1212
left a comment
There was a problem hiding this comment.
Just a small nit, otherwise LGTM!
Salvaged from PR #459
Refactor the CRS testing tooling a bit: no macro, retry each task independently, move helper to
common. In short: some TLC for CRS tests.